Skip to content

fix: update tree pattern expand icon direction#12554

Open
mcoker wants to merge 2 commits into
patternfly:mainfrom
mcoker:issue-12553
Open

fix: update tree pattern expand icon direction#12554
mcoker wants to merge 2 commits into
patternfly:mainfrom
mcoker:issue-12553

Conversation

@mcoker

@mcoker mcoker commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

fixes #12553

Updates the following tree patterns to use the right/down arrows instead of down/up

Summary by CodeRabbit

  • Bug Fixes
    • Fixed expand/collapse toggle indicators to use the correct right-facing caret icon across Tree View, Dual List Selector tree items, and table tree rows.
  • Style
    • Updated PatternFly styling components to a newer prerelease version to keep UI visuals aligned with the latest updates.

@mcoker mcoker requested review from kmcfaul and thatblindgeye July 10, 2026 01:00
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Updates five PatternFly package references to 6.6.0-prerelease.18 and changes tree expand/collapse toggle icons from caret-down to caret-right in TreeView, DualListSelector, and table tree rows.

Changes

Tree caret and PatternFly updates

Layer / File(s) Summary
PatternFly prerelease dependency alignment
packages/react-core/package.json, packages/react-docs/package.json, packages/react-icons/package.json, packages/react-styles/package.json, packages/react-tokens/package.json
Pins @patternfly/patternfly dependencies or devDependencies to 6.6.0-prerelease.18.
Tree toggle caret updates
packages/react-core/src/components/{TreeView,DualListSelector}/*, packages/react-table/src/components/Table/utils/decorators/treeRow.tsx
Replaces rendered caret-down toggle icons with RhMicronsCaretRightIcon and updates the corresponding imports.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: kmcfaul, nicolethoen, wise-king-sullyman

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR updates treeview-related caret icons from down to right, matching the linked issue's requested expand icon change.
Out of Scope Changes check ✅ Passed The dependency bumps and icon swaps are coherent with the tree icon update and do not show unrelated scope creep.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: updating tree expand icon direction in the tree components.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

@thatblindgeye thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, should we also update where wew're using a tree view outside the actual component, like the DualListSelector with tree implementation?

@mcoker mcoker changed the title fix(tree-view): update expand icon direction fix: update tree pattern expand icon direction Jul 15, 2026
@mcoker mcoker requested a review from thatblindgeye July 15, 2026 20:28
@mcoker

mcoker commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@thatblindgeye nice catch. Confirmed with design, all tree patterns should be updated. Updated the PR so it changes:

Need to merge the CSS change from patternfly/patternfly#8502 for this PR to look right, since that changes the rotation from 180deg to 90deg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update treeview expand icon

3 participants