Skip to content

update recipe flags on zimfarm - #448

Merged
elfkuzco merged 1 commit into
mainfrom
solve-book-metadata-issue
Jul 30, 2026
Merged

update recipe flags on zimfarm#448
elfkuzco merged 1 commit into
mainfrom
solve-book-metadata-issue

Conversation

@elfkuzco

Copy link
Copy Markdown
Contributor

Rationale

This PR adds functionality to the UI to update flags responsible for recipe metadata from the CMS. During book promotion actions, if there are actions to update title metadata, UI loads recipe details and informs user to make corresponding changes to the zimfarm recipe that created the book

Changes

  • prompt user to update appropriate flags that are responsible for the metadata on zimfarm
  • add methods to authenticate with zimfarm in cms auth store
  • upload base64 blobs that are responsible for Illustration metadata to zimfarm before applying the patch with the returned URL
Screenshot_20260728_031111 Screenshot_20260728_031119 Screenshot_20260728_031138 Screenshot_20260728_031148

This closes #333

@elfkuzco elfkuzco self-assigned this Jul 28, 2026
@elfkuzco
elfkuzco requested a review from benoit74 July 28, 2026 02:29
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.04%. Comparing base (69ba5bf) to head (cc2c6ba).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   81.02%   81.04%   +0.01%     
==========================================
  Files          65       65              
  Lines        3879     3883       +4     
  Branches      472      472              
==========================================
+ Hits         3143     3147       +4     
  Misses        583      583              
  Partials      153      153              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks a lot like what I expected, with even some improvements over few things I wrongly anticipated (like we always have at most one recipe to update, never two, since we are promoting a book so there is one single recipe attached ...)

Comment thread frontend/src/components/RecipeUpdateDialog.vue
Comment thread frontend/src/components/RecipeUpdateDialog.vue Outdated
@elfkuzco
elfkuzco requested a review from benoit74 July 30, 2026 09:55

@benoit74 benoit74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elfkuzco
elfkuzco force-pushed the solve-book-metadata-issue branch from 5ced668 to cc2c6ba Compare July 30, 2026 14:09
@elfkuzco
elfkuzco merged commit 5f8d26a into main Jul 30, 2026
4 of 5 checks passed
@elfkuzco
elfkuzco deleted the solve-book-metadata-issue branch July 30, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better solve book metadata issue

2 participants