Feature: PTP Peer-to-Peer (P2P) Path Delay Support - #2324
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
c9b91ab to
3ff98d8
Compare
| _Out_ char *buffer, | ||
| _In_ const sai_ptp_l2_header_t header) | ||
| { | ||
| return 0; |
There was a problem hiding this comment.
missing serialization method
| _In_ const char *buffer, | ||
| _Out_ sai_ptp_l2_header_t header) | ||
| { | ||
| return 0; |
There was a problem hiding this comment.
missing serialization method
| return (int)(buf - buffer); | ||
| } | ||
|
|
||
| int sai_serialize_ptp_clock_id( |
There was a problem hiding this comment.
if you are adding serialize and dserialize, then add also unittest for that
There was a problem hiding this comment.
custom serializer removed. applies to other comments as well.
| id[n] = (uint8_t)arr[n]; | ||
| } | ||
|
|
||
| return 8; |
There was a problem hiding this comment.
it should return "read" variable, number of consumed characters, take a look at sai_deserialize_mac and sai_deserialize_object_id
| CHECK_STRUCT_SIZE(sai_acl_field_data_data_t, 16); | ||
| CHECK_STRUCT_SIZE(sai_acl_field_data_mask_t, 16); | ||
| CHECK_STRUCT_SIZE(sai_attribute_value_t, 40); | ||
| CHECK_STRUCT_SIZE(sai_attribute_value_t, 64); |
There was a problem hiding this comment.
this is breaking (not backward compatible) change as attribute value size is changing
There was a problem hiding this comment.
fixed to use sai_u8_list_t instead
2c81938 to
06a3bb1
Compare
Adds the headers and design specification for the PTP Pdelay configuration object, expanding SAI capabilities to configure localized hardware measurement profiles for link propagation delays. This incorporates the v3 struct simplifications, utilizing standard sai_u8_list_t mappings to preserve SAI ABI compatibility. Signed-off-by: gurprem <gurprem@google.com>
06a3bb1 to
d7ba673
Compare
|
Thanks for review @kcudnik. Latest patch is updated so both attributes now use the standard sai_u8_list_t instead. This keeps the union at 40 bytes, and since it's a natively-supported type, it no longer needs any custom serialize/deserialize methods or their unit tests. |
2 participants
Adds the headers and design specification for the PTP Pdelay configuration object, expanding SAI capabilities to configure localized hardware measurement profiles for link propagation delays.