Update to React 19#1705
Conversation
With "usehooks-ts". The previous library is blocking our update to React 19 and it is unclear whether that will ever change.
Minimal viable dependency updates to finally get React 19.
React 19 does not require a lot of changes, but some. Also needed to disable a typescript rule because typescript got confused.
|
This pull request is deployed at test.editor.opencast.org/1705/2026-05-22_12-16-10/ . |
Lots of major changes with this update. Will have to see if and how this might influence behaviour. Seems to allow us to get rid of our custom patched version though, which I like.
New major has quite a few changes, but ultimately things should work the same as before.
Was because of dependency upgrade
be77113 to
1f86b2b
Compare
There were previously used in the Metadata component. With the rewrite of the metadata component, they were only used for one Select in the subtitle select, for which they are totally overkill. This removes them, and instead uses a Select from mui material.
due to undefined error
owi92
left a comment
owi92
left a comment
There was a problem hiding this comment.
I have tested this and couldn't find any obvious issues. However I am not an avid editor user, so take this with a grail of salt. For my tests I simply tried all functions (basically just clicked through the interface) and compared with https://editor.opencast.org/19.x/ (https://editor.opencast.org/develop/ appears to be broken).
Code looks generally fine too. My comments are just some code suggestions that do equivalent things compared to what's already in place, but they are a little nicer imo.
Implements various suggestions by @owi92 that make the code just that little bit nicer.
|
And thank you for thoroughly testing this and even adding all these suggestions to make the code a little nicer :) |
2 participants
Fixes #1643.
react-beforeunloadadded support for React 19, anduse-resize-observerwas replaced.Bunch of other dependencies received major version updates too.