feat(amp): add deterministic native workflows - #132
Open
oliver-kriska wants to merge 3 commits into
Open
Conversation
Generate a complete Amp target with explicit palette commands, read-only specialists, bounded parallel analysis, and lifecycle guards. Keep the source target byte-identical to the validated standalone distribution and cover the runtime policies with model-free tests and smoke checks. Co-authored-by: Oliver Kriska <oliver@ideax.sk>
oliver-kriska
force-pushed
the
feat/amp-native-workflows
branch
from
August 11, 2026 10:11
6739495 to
e5b8b6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refresh the canonical Amp integration on current
mainand make its workflow behavior deterministic where the supported Plugin API allows. The generated target includes all 51 Agent Skills, 40 paired-local workflow wrappers, five native controls, five read-only specialists, bounded parallel analysis, and lifecycle safety controls.This branch was rebased from the original #132 onto
mainat3f0f117; generated artifacts were regenerated from canonical source rather than conflict-merged. The installable artifacts remain owned here and will be projected from the reviewed commit into the separately gatedamp-elixir-phoenixdistribution PR.What changes
Readandfinder.phx-fullverification gate..agents/skillsand.claude/skillsfrom exposedworkspaceRootthrough its parents, then the legacy home fallback.skill: invoke, hosted-native versus paired-full profiles, machine-local versus personal/workspace hosted scope, independent skills/plugin publication, and skills-first rollout ordering.stable, paired local install, and GitHub/curl compatibility paths.Explicit Plugin API boundary
Native
skill: invokeuses Amp's effective resolver and supports local, built-in, personal hosted, and workspace hosted skills. The current Plugin API does not expose skill resolution/invocation or Amp's original nested invocation directory, so filesystem wrappers cannot correctly inject hosted-only, built-in, plugin-cache, custom-path, or unexposed nested skill bodies.Consequently:
phx: fullarms the plugin verification gate; native hostedskill: invoke→phx-fullfollows skill guidance but cannot activate that wrapper hook.The implementation documents this boundary instead of scanning undocumented Amp caches or claiming unsupported hosted wrapper behavior.
Safety and distribution
Specialists cannot edit, run shell commands, or recursively create agents. Edit-lock paths resolve symlinks and fail closed on malformed, unreadable, or workspace-escaping state. Verification rejects piped, chained, neutralized, pre-edit, unrelated-PID, and nonzero-exit checks.
The generated plugin deliberately retains the direct GitHub/curl fallback. Promotion to the standalone distribution and mutable
stableremains separately review-gated; neither is changed by this canonical PR.Verification
Canonical commit:
3ea78b0fbae186840121aace789e86fe70e361dcmake ci— PASS: 243 tests (including the Bun runtime harness), Claude manifest validation, all generated-target drift/snapshot checks, and full structural eval (51 skills, 26 agents). Skillspector was not installed in the orb, so the Makefile's optional security target reported its documented skip.make amp-runtime-smoke— PASS with Amp0.0.1786436318-g8453bf(2026-08-11): 51 skills and plugin loaded in isolation without model calls.make amp-target-validate— PASS: 51 skills and plugin, with regenerated golden snapshot.npm audit --audit-level=high, andgit diff --check— PASS; npm audit found 0 vulnerabilities.Review focus
The highest-value review areas are the documented hosted-wrapper boundary, local resolver precedence, Amp lifecycle assumptions, edit-lock enforcement, verification result classification, and generator-to-target parity.