[ADD] estate: add estate module for tutoriel - #1370
Open
jeanbfly wants to merge 20 commits into
Open
Conversation
|
|
added 9 commits
July 22, 2026 11:22
…ir views. Try onchange, compute and inverse
YassinWalid
requested changes
Jul 27, 2026
YassinWalid
left a comment
YassinWalid
left a comment
There was a problem hiding this comment.
Thanks for the incredible work. As an initial review, I left some comments in the PR, and some general ones below.
Don't forget to add an empty line at the end of each file. We mostly do this for a clean history, since if somebody adds a line at the end of the file, they'll technically be changing your line as well, messing up the git blame or history of that specific line.
For the order of attributes in the model, the naming of the xml ids, and other guidelines, you can follow the coding guidelines.
One minor comment, why do you put the string of your views "Channel", "Test", etc.?
added 9 commits
July 27, 2026 15:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.