refactor(auth): derive the org-role vocabulary from @objectstack/spec instead of mirroring it by os-zhuang · Pull Request #3038 · objectstack-ai/objectui

os-zhuang · 2026-07-30T13:04:15Z

Closes #2908 — the follow-up #2907 recorded as blocked. All three unblock conditions now hold:

✅ The vocabulary is closed (framework ADR-0108, feat(auth)!: membership grade is not a capability channel — close the sys_member.role vocabulary (ADR-0108, #3723) objectstack#3802).
✅ @object-ui/auth now depends on @objectstack/spec (this PR, ^17.0.0-rc.0 like every other package).
✅ The constants are published: @objectstack/spec@17.0.0-rc.0 on npm ships BUILTIN_MEMBERSHIP_ROLES / MEMBERSHIP_ROLE_*, verified against the installed dist. The ^16 → ^17 sequencing wrinkle the issue flagged resolved itself when the workspace moved to ^17.0.0-rc.0.

What changed

The four ORG_ROLE_* consts are now rename-re-exports of the spec's MEMBERSHIP_ROLE_* literals; OrgRole = BuiltinMembershipRole; ORG_ROLES = [...BUILTIN_MEMBERSHIP_ROLES] (the spec array is already in the display order the screens use — verified identical values and order at runtime).
Kept local, per the issue: ORG_ROLE_LABELS and the grade ladder (orgRoleGrade, invitableOrgRoles, assignableOrgRoles) — console concerns (i18n keys, screen-narrowing), per ADR-0108 D4.
Dropped docs(auth): the org-role vocabulary is closed — correct the mirror's standing instruction (framework ADR-0108) #2907's drift guard (is EXACTLY the framework four) — a derived list cannot drift. The feat(console): make delegated_admin reachable and narrow both role pickers (framework#3697) #2891 toContain(delegated_admin) test stays, reframed: it pins a console decision (ORG_ROLES is the spec list unfiltered), which types don't enforce.
Public API of @object-ui/auth is unchanged (same names, same literal types); app-shell consumers type-check untouched.

Verification

vitest run packages/auth — 8 files, 106 tests pass
@object-ui/auth + @object-ui/app-shell type-check pass; lint 0 errors (no new warnings)
Lockfile: no second spec instance / zod@3 peer-variant fork (grep -c "zod@3.25.76))" pnpm-lock.yaml → 0)
Runtime: BUILTIN_MEMBERSHIP_ROLES = ["owner","admin","delegated_admin","member"] from the installed package

🤖 Generated with Claude Code

… instead of mirroring it The four ORG_ROLE_* constants become re-exports of the spec's MEMBERSHIP_ROLE_* literals, OrgRole becomes BuiltinMembershipRole, and ORG_ROLES becomes [...BUILTIN_MEMBERSHIP_ROLES] — the same constant the enforced sys_member.role select is built from, so the console's list can no longer drift from what the server accepts. Unblocked by @objectstack/spec@17.0.0-rc.0 (first release carrying framework ADR-0108's closed vocabulary) and the workspace's move to ^17.0.0-rc.0. ORG_ROLE_LABELS and the grade ladder stay console-owned per ADR-0108 D4; the #2907 drift guard is dropped — a derived list cannot drift. Closes #2908 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

vercel · 2026-07-30T13:04:22Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 30, 2026 1:04pm

github-actions · 2026-07-30T13:07:59Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	27.9 KB	350 KB
Entry file	`index-1S8_G_bd.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.20KB	2.97KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.86KB	5.29KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.43KB	2.09KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	457.71KB	100.07KB
core (index.js)	2.16KB	0.78KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	134.67KB	34.24KB
fields (index.js)	222.07KB	54.35KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	25.17KB	5.80KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.45KB	10.67KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	6.84KB	2.42KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.90KB	12.35KB
plugin-charts (index.js)	60.52KB	17.11KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	111.59KB	28.74KB
plugin-designer (index.js)	210.56KB	42.56KB
plugin-detail (index.js)	221.50KB	54.15KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	106.35KB	25.82KB
plugin-gantt (index.js)	162.26KB	39.53KB
plugin-grid (index.js)	183.96KB	48.23KB
plugin-kanban (index.js)	47.82KB	13.18KB
plugin-list (index.js)	102.39KB	24.18KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	40.32KB	10.53KB
plugin-timeline (index.js)	25.75KB	7.32KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	85.91KB	20.99KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	3.47KB	1.54KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	2.00KB	0.96KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.04KB	1.93KB
types (system-fields.js)	2.39KB	1.17KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	1.08KB	0.64KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added dependencies tests labels Jul 30, 2026

os-zhuang merged commit fc60ad3 into main Jul 30, 2026
16 checks passed

os-zhuang deleted the claude/org-role-vocab-objectstack-5f3b35 branch July 30, 2026 13:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(auth): derive the org-role vocabulary from @objectstack/spec instead of mirroring it - #3038

refactor(auth): derive the org-role vocabulary from @objectstack/spec instead of mirroring it#3038
os-zhuang merged 1 commit into
mainfrom
claude/org-role-vocab-objectstack-5f3b35

os-zhuang commented Jul 30, 2026

Uh oh!

vercel Bot commented Jul 30, 2026

Uh oh!

github-actions Bot commented Jul 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

os-zhuang commented Jul 30, 2026

What changed

Verification

Uh oh!

vercel Bot commented Jul 30, 2026

Uh oh!

github-actions Bot commented Jul 30, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant