docs: clarify AttributeConstraint works on ICustomAttributeProvider, not arbitrary instances#1189
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix attribute constraint not working on all instances
docs: clarify AttributeConstraint works on ICustomAttributeProvider, not arbitrary instances
Jul 3, 2026
stevenaw
requested changes
Jul 3, 2026
Co-authored-by: Steven Weerdenburg <stevenaw@users.noreply.github.com>
stevenaw
approved these changes
Jul 3, 2026
OsirisTerje
approved these changes
Jul 3, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 3, 2026
…issue docs: clarify AttributeConstraint works on ICustomAttributeProvider, not arbitrary instances 5b673c3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs incorrectly stated that
AttributeConstraintandAttributeExistsConstraintwork on "both Type objects and instances (testing the instance's type)." In reality, they work on any object implementingICustomAttributeProvider— passing an arbitrary class instance that doesn't implement it throws anArgumentException.Changes
AttributeConstraint.md— Replace note 3 with accurate description: the constraint works onICustomAttributeProviderimplementers (Type,MethodInfo,Assembly, etc.), and explicitly notes that passing an arbitrary instance results in an error.AttributeExistsConstraint.md— Same correction applied to note 3.The previously documented behavior would lead users to expect this to work: