tools: fix shared-lib build on V8 cache miss#64635
Closed
bitpshr wants to merge 1 commit into
Closed
Conversation
The first `download-artifact` step in build-shared.yml does not name an artifact, so it downloads every artifact from the run. On a V8 cache miss the libv8 NAR is also present, and downloading multiple artifacts places each in its own directory, nesting the tarball one level deeper. `tar xzf tarballs/*.tar.gz` then matches a directory and fails. Set `merge-multiple: true` so the artifacts are flattened into `tarballs`, matching the single-artifact layout the extract step expects. The NAR is still downloaded separately by name for the V8 step. Fixes: nodejs#64554 Signed-off-by: Paul Bouchon <mail@bitpshr.net>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
Member
|
Seems duplicated with #64633. |
Contributor
Author
|
You're right, this is the same fix as #64633, and pinning it with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
Test Shared librariesworkflow failing on a V8 cache miss for fork PRs (#64554).The first
download-artifactstep inbuild-shared.ymldoesn't name an artifact, so on a cache miss it pulls in the libv8 NAR alongside the tarball. With multiple artifacts, each lands in its own directory, sotar xzf tarballs/*.tar.gzends up matching a directory and fails. Settingmerge-multiple: trueflattens them back intotarballs, matching the single-artifact layout the extract step expects. The NAR is still downloaded separately by name for the V8 step.Fixes: #64554