Skip to content

net: support TCP handle transfer on Windows#64460

Open
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:tcp-transfer-windows
Open

net: support TCP handle transfer on Windows#64460
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:tcp-transfer-windows

Conversation

@mcollina

Copy link
Copy Markdown
Member

Adds Windows support for transferring TCP handles across worker threads.

Fixes: #64456

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 12, 2026
@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.24%. Comparing base (dca0fd1) to head (060c604).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/tcp_wrap.cc 50.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64460      +/-   ##
==========================================
- Coverage   90.24%   90.24%   -0.01%     
==========================================
  Files         741      741              
  Lines      241603   241596       -7     
  Branches    45523    45530       +7     
==========================================
- Hits       218038   218022      -16     
+ Misses      15109    15100       -9     
- Partials     8456     8474      +18     
Files with missing lines Coverage Δ
lib/internal/errors.js 97.71% <ø> (-0.01%) ⬇️
lib/net.js 94.54% <ø> (+0.19%) ⬆️
src/tcp_wrap.h 57.14% <100.00%> (+3.29%) ⬆️
src/tcp_wrap.cc 68.85% <50.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

net: add Windows support for TCP handle transfer across worker threads

3 participants