Document interaction with SNI for more SSL directives - #300
Open
pluknet wants to merge 1 commit into
Open
Conversation
bavshin-f5
reviewed
Jul 27, 2026
Comment on lines
+389
to
+391
| are performed by the OpenSSL library | ||
| before the server configuration could be applied according to SNI, | ||
| thus, such directives should be specified only for a default server; |
Member
There was a problem hiding this comment.
ssl_protocols can be applied after the SNI server selection since 1.29.2, as proven by the ssl_sni_protocols.t (OpenSSL >= 1.1.1, BoringSSL or AWS-LC). This makes the recommendation for ssl_protocols outdated and misleading.
Collaborator
Author
There was a problem hiding this comment.
I reworked this part in 4592bea, please check if it's good for you
pluknet
force-pushed
the
ssl-default-server
branch
from
August 4, 2026 15:08
9f7be78 to
4592bea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.