Skip to content

Revert "ci: Skip flaky playwright test for now" - #851

Draft
juliusknorr wants to merge 1 commit into
mainfrom
revert-850-ci/skip-flaky-test
Draft

Revert "ci: Skip flaky playwright test for now"#851
juliusknorr wants to merge 1 commit into
mainfrom
revert-850-ci/skip-flaky-test

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

Reverts #850

needs work

@hweihwang

Copy link
Copy Markdown
Contributor

Close as current seems fine. cc @juliusknorr !

@hweihwang hweihwang closed this Jan 28, 2026
@juliusknorr juliusknorr reopened this Jan 28, 2026
@juliusknorr

Copy link
Copy Markdown
Member Author

No, we skipped a test that was failing and still is. This PR is the reminder to revert the skip and fix it, so this still needs to be done. If the test is not relevant we should drop it

@KhyFee KhyFee left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-enabling whiteboard content persists after reload and reopen is the right long-term move — skipping it forever hides regressions.

Before merging, I’d want evidence the original flake is actually gone:

  1. Link/CI showing this spec green across multiple retries (or a few consecutive CI runs), not just a single pass.
  2. If the flake was timing/reload related, consider a small harden in the same PR: wait for a stable board ready signal after reopen (network idle / specific locator) instead of only removing test.skip.
  3. Optional: tag it @flaky / quarantine with retries for one release if you’re still unsure, then fully un-skip.

As written this is a 1-line revert — fine if CI already proves stability; risky if the skip was recent and unfixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants