Revert "ci: Skip flaky playwright test for now" - #851
Draft
juliusknorr wants to merge 1 commit into
Draft
Conversation
This reverts commit c35f887.
Contributor
|
Close as current seems fine. cc @juliusknorr ! |
Member
Author
|
No, we skipped a test that was failing and still is. This PR is the reminder to revert the skip and fix it, so this still needs to be done. If the test is not relevant we should drop it |
KhyFee
reviewed
Aug 3, 2026
KhyFee
left a comment
There was a problem hiding this comment.
Re-enabling whiteboard content persists after reload and reopen is the right long-term move — skipping it forever hides regressions.
Before merging, I’d want evidence the original flake is actually gone:
- Link/CI showing this spec green across multiple retries (or a few consecutive CI runs), not just a single pass.
- If the flake was timing/reload related, consider a small harden in the same PR: wait for a stable board ready signal after reopen (network idle / specific locator) instead of only removing
test.skip. - Optional: tag it
@flaky/ quarantine with retries for one release if you’re still unsure, then fully un-skip.
As written this is a 1-line revert — fine if CI already proves stability; risky if the skip was recent and unfixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #850
needs work