chore: migrate to ESM - #1824
Draft
ShGKme wants to merge 10 commits into
Draft
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me> Assisted-by: ClaudeCode:claude-opus-4-8
Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Currently, this plugin is not completely compatible with ESM. It uses new URL for paths and replaces space with %20. It breaks accessing Windows Registry if installation path has spaces. For example, `Nextcloud Talk`. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
added
technical debt
Antreesy
approved these changes
Jul 24, 2026
Antreesy
left a comment
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Code-wise looks OK, smoke-tested windows build, see no issues so far
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Migrate to ESM
package.json/typeandpackage.json/main.mjsto.jsnew URL('...', import.meta.url)Remove
@vercel/webpack-asset-relocator-loaderfor.nodeloading.nodemodulesNextcloud TalkbecomesNextcloud%20Talk, breaking loading).nodefile, we can load it manually with 2 lines of codePatch
@electron-forge/plugin-webpackfor ESm supportUnfortunately, the plugin isn't ready for ESM support yet.
Adding a small patch with
patch-package.AI (if applicable)