LinkGenerator: extract interface#273
Open
PavelJurasek wants to merge 7 commits into
Open
Conversation
Member
|
What is the interface for? Replace it with your own implementation. |
Contributor
Author
|
Right, I can change service
|
PavelJurasek
force-pushed
the
feat-link-generator-interface
branch
from
January 19, 2021 12:13
b901a27 to
6739750
Compare
Member
|
@PavelJurasek I'll save this as a beautiful argument when someone wonders why I'm removing the letter |
PavelJurasek
force-pushed
the
feat-link-generator-interface
branch
from
January 19, 2021 12:52
f230978 to
febdc2b
Compare
PavelJurasek
force-pushed
the
feat-link-generator-interface
branch
from
January 19, 2021 12:57
febdc2b to
2f18bdc
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
January 26, 2021 21:24
13f5ab3 to
c15bd94
Compare
dg
force-pushed
the
master
branch
9 times, most recently
from
February 8, 2021 05:57
7de5809 to
f817a0b
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
August 29, 2021 21:33
6e85bcc to
10d0d39
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
September 12, 2021 21:52
31e6d6d to
af52aa4
Compare
dg
force-pushed
the
master
branch
8 times, most recently
from
October 11, 2021 10:37
7ade054 to
8cca00e
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
October 19, 2021 23:53
37d1dbf to
781992c
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
November 8, 2021 22:07
e61605d to
3ded4e1
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
December 12, 2021 16:37
059a3ee to
4e78fc4
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
December 22, 2021 00:50
af03d73 to
33f96e6
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
March 25, 2022 14:38
3013dde to
9d383a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since LinkGenerator is final, it would be nice if it had its own interface so that it can be replaced with own implementation.