Complete engine architecture contracts#33
Merged
Conversation
ncode
marked this pull request as ready for review
July 17, 2026 06:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The prior descriptor metadata described multiple gating classes that the executor did not honor, so fully disabled multi-output/shared resolvers still performed probe work. Discovery policy also depended on mutable package globals used by tests, and several test-only helper paths overstated the live production surface.
This change makes the catalog the executable scheduling contract, keeps ambient inputs local to each invocation, and removes false surface without changing the public Facts tree or CLI compatibility boundary.
Validation
go test ./...— 2,413 testsgo test -race . ./internal/engine ./internal/app— 2,266 testsgo test -shuffle=on -count=5 . ./internal/engine ./internal/app— 9,386 testsgo vet ./...,make build,git diff --checkopenspec validate complete-engine-architecture-contracts --strict