fix: map text-align start/end to left/right for RN compatibility - #397
Open
mubeess wants to merge 1 commit into
Open
fix: map text-align start/end to left/right for RN compatibility#397mubeess wants to merge 1 commit into
mubeess wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tailwind CSS v4 generates
text-align: startandtext-align: endfor thetext-startandtext-endutility classes. These are CSS logical values that depend on writing direction.React Native's
textAlignprop does not supportstartorendvalues — onlyauto,left,right,center, andjustify. Previously, these values were silently dropped (returnedundefinedwith a warning).Fix
start→ mapped toleftend→ mapped torightThis matches the LTR default behavior and is a pragmatic fallback since React Native doesn't support direction-aware text alignment.
Files Changed
src/compiler/declarations.tsstart→leftandend→rightmapping inparseTextAlignsrc/__tests__/vendor/tailwind/typography.test.tsxtext-startandtext-endtestsTesting
yarn test: 1053 passed (1051 existing + 2 new)yarn lint: cleanyarn typecheck: cleanChecklist