winmm: Fix use-after-free race between stream destroy and buffer thread. - #854
Open
kinetiknz wants to merge 1 commit into
Open
winmm: Fix use-after-free race between stream destroy and buffer thread.#854kinetiknz wants to merge 1 commit into
kinetiknz wants to merge 1 commit into
Conversation
Destroy could free a stream while buffer thread work items referencing it were still queued or in flight, particularly after a data callback error. Count pending work items per stream (and in-flight driver callbacks per context) and make destroy wait for them to drain. Also fix free_buffers accounting on refill's error paths so the wait terminates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destroy could free a stream while buffer thread work items referencing it were still queued or in flight, particularly after a data callback error. Count pending work items per stream (and in-flight driver callbacks per context) and make destroy wait for them to drain. Also fix free_buffers accounting on refill's error paths so the wait terminates.