chore(filesystem): remove unused glob dependency#4535
Open
shotty1 wants to merge 1 commit into
Open
Conversation
The filesystem server declared glob as a dependency but never imported it. All glob-style pattern matching is done via minimatch. glob had been present since v0.6.2 but was never used in any version of the source; Dependabot kept bumping it (most recently to 10.5.0), which is why it persisted unnoticed. Removing it drops a transitive dependency subtree and clears the glob@10.5.0 deprecation warning shown on install. Build (tsc) and all 152 tests pass with the dependency removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
filesystemserver declaresglobas a dependency but never imports it — all glob-style pattern matching is done viaminimatch.globhas been present since v0.6.2 (Dec 2024) but was never used in any version of the source; Dependabot has kept bumping it (most recently to10.5.0in #3076), which is why it went unnoticed.Removing it drops a transitive dependency subtree and clears the
glob@10.5.0deprecation warning shown onnpm install:Server Details
Motivation and Context
The unused
globdependency emits a deprecation warning on install and pulls in an unnecessary transitive tree. Since it is not referenced anywhere in the server (source, tests, build scripts), removing it is a cleaner fix than a version bump.How Has This Been Tested?
npm installregenerates the lockfile with no remainingglob@10entries;globis no longer resolvable from thefilesystemworkspace.npm run build(tsc) succeeds.npm test— all 152 tests across 7 files pass.Breaking Changes
None. The dependency was unused, so there is no runtime behavior change and no client configuration impact.
Types of changes
Checklist
Note: "tested with an LLM client" is not applicable — this is a dependency-only change with no behavioral effect.