fix(everything): return errors for missing SSE sessions#4533
Open
dev-willbird1936 wants to merge 1 commit into
Open
fix(everything): return errors for missing SSE sessions#4533dev-willbird1936 wants to merge 1 commit into
dev-willbird1936 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Return clear 404 JSON responses when the deprecated Everything SSE transport receives an unknown or missing session ID. The affected routes previously logged and left requests unresolved, or dereferenced a failed lookup.
Root cause
The deprecated SSE transport did not consistently validate session lookup before handling
GET /sseandPOST /messagerequests.Testing
GET /sseandPOST /messagesessions: 2/2 passed.git diff --checkpassed.This is an ordinary correctness/resource-handling fix, not a security report. Hosted CI and maintainer review remain pending.