Cleaning up some package.json invalid syntax#22394
Open
Benjin wants to merge 2 commits into
Open
Conversation
Benjin
requested review from
aasimkhan30,
allancascante,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez and
ssreerama
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates extension manifest (package.json) contributions to address schema/syntax issues and adjust contribution metadata for the MSSQL and Data Workspace extensions.
Changes:
- Fixes
extensions/mssql/package.jsoncontribution JSON by adding a missing comma and introducing an icon for thequeryResultview. - Removes an invalid
languagefield from thecustomEditorsselector for*.sqlplanexecution plans. - Removes
activationEventsfromextensions/data-workspace/package.json, changing the extension’s activation behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| extensions/mssql/package.json | Fixes manifest schema/syntax and adjusts view/custom editor contribution metadata. |
| extensions/data-workspace/package.json | Removes activation events, which changes when the extension is activated. |
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22394 +/- ##
==========================================
- Coverage 87.75% 87.74% -0.02%
==========================================
Files 326 326
Lines 114730 114730
Branches 558 558
==========================================
- Hits 100687 100672 -15
- Misses 14043 14058 +15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines