Don't report Node deprecation warnings as script errors - #14616
Merged
sean-mcmanus merged 2 commits intoJul 29, 2026
Merged
Conversation
runVSCodeCommand only resolves on success (it throws on a non-zero exit), so its stderr is non-fatal output such as the Node [DEP0169] url.parse() deprecation warning emitted by the VS Code CLI. Log it as a warning instead of an error in installAndCopyBinaries.ts, and add DEP0169 to the test.ts stdio filter list.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the extension’s test/CI helper scripts so that non-fatal stderr output (notably Node deprecation warnings like DEP0169) is not surfaced as a hard error when the underlying VS Code CLI command succeeds. This reduces noisy “ERROR” log output while keeping genuine failures unchanged.
Changes:
- Treat successful
runVSCodeCommandstderr output as a warning (not an error) ininstallAndCopyBinaries.ts. - Suppress
DEP0169deprecation warning lines intest.tsstdout/stderr filtering to keepyarn testoutput clean.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Extension/.scripts/test.ts | Adds DEP0169 to the stdio filter deny-list to suppress harmless Node deprecation output during tests. |
| Extension/.scripts/installAndCopyBinaries.ts | Logs runVSCodeCommand stderr as warn() (non-fatal) rather than error() when the command succeeds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bobbrow
approved these changes
Jul 29, 2026
…deprecation-warning
Colengms
approved these changes
Jul 29, 2026
sean-mcmanus
deleted the
seanmcm/devbox2-wsl/agent6/no-error-on-node-deprecation-warning
branch
July 29, 2026 16:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yarn install-and-copy-binaries-for-testprinted a redERROR:for a harmless Node[DEP0169] url.parse()deprecation warning that the VS Code CLI writes to stderr, even though the extension installed successfully and the binaries were copied. The script callederror()unconditionally whenever the--install-extensionsubprocess produced any stderr output.runVSCodeCommandonly resolves when the command succeeds (it throwsVSCodeCommandErroron a non-zero exit), so its stderr here is inherently non-fatal (e.g. Node deprecation warnings). It is now logged withwarn()instead oferror(), which handlesDEP0169and any future deprecation warning without an allow-list.The same
DEP0169pattern is also added to thetest.tsfilterStdio()deny-list, alongside the existingDEP0005entry, so theyarn testpath stays quiet as well.