Skip to content

Normalize JSON trailing newlines. - #14579

Merged
sean-mcmanus merged 6 commits into
mainfrom
seanmcm/updateIntelliSenseStringAddJsonNewlines
Jul 28, 2026
Merged

Normalize JSON trailing newlines.#14579
sean-mcmanus merged 6 commits into
mainfrom
seanmcm/updateIntelliSenseStringAddJsonNewlines

Conversation

@sean-mcmanus

@sean-mcmanus sean-mcmanus commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Normalize JSON trailing newlines.

Fixed by Copilot (Claude Opus 4.8) in VS Code.

Summary

Makes JSON trailing newlines consistent
across the extension and stops them from being silently stripped on save.

JSON trailing-newline consistency

Two settings in .vscode/settings.json disagreed: [jsonc] inserted a final
newline on save, but [json] did not. Because [json] also formats on save,
saving any .json file reformatted it and then dropped the trailing newline,
producing spurious diffs whenever a JSON file was opened and saved. Several
files had already lost their final newline this way.

Changes:

  • .vscode/settings.json: set files.insertFinalNewline to true for [json]
    (it was false), matching [jsonc]. Saving a JSON file no longer strips the
    trailing newline.
  • Normalized all tracked .json files to end with a single trailing newline,
    including the generated i18n/**/*.i18n.json translation files.
  • gulpfile.js (translations-import): append a trailing newline to each
    generated .i18n.json after it is written, so future translation imports keep
    the files consistent with the convention above. The existing generators for
    bin/messages and package.json already write a trailing newline, so no
    change was needed there.

Notes

  • No behavioral change to the extension beyond preventing the localized failure
    described above; the remaining changes are whitespace-only and tooling.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@sean-mcmanus

sean-mcmanus commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

These shouldn't get checked in until the corresponding cpptools side PR 757614 gets approved.

UPDATE: The IntelliSense string changes were moved to #14607 .

Colengms
Colengms previously approved these changes Jul 14, 2026
@sean-mcmanus sean-mcmanus changed the title Add a new IntelliSense translation string and normalize JSON trailing newlines. Normalize JSON trailing newlines. Jul 26, 2026
@sean-mcmanus
sean-mcmanus requested a review from Copilot July 26, 2026 17:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@sean-mcmanus
sean-mcmanus merged commit 397f4e5 into main Jul 28, 2026
6 checks passed
@sean-mcmanus
sean-mcmanus deleted the seanmcm/updateIntelliSenseStringAddJsonNewlines branch July 28, 2026 00:00
@github-project-automation github-project-automation Bot moved this from Pull Request to Done in cpptools Jul 28, 2026
sean-mcmanus added a commit that referenced this pull request Jul 28, 2026
* Some IntelliSense loc changes. (#14571)

* Support requests of multiple custom configs (#14582)

* Add an opt-in for capturing sanitizer logs from the language server (#14573)

* Add an opt-in for capturing sanitizer logs from the language server

* Add localizable strings for --check headless validation (#14578)

* Add localizable strings for --check headless validation

Adds 13 native strings backing the mscppls --check mode (the clangd-style
headless validation of a compile_commands.json file): the two --help entries
and the setup/usage error messages.

* No lock on placeholders

* Fix LOC locks

* send telemetry for language client errors (#14577)

* Bump brace-expansion and @vscode/vsce in /Themes (#14591)

Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) to 5.0.7 and updates ancestor dependency [@vscode/vsce](https://github.com/Microsoft/vsce). These dependencies need to be updated together.


Updates `brace-expansion` from 1.1.13 to 5.0.7
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](juliangruber/brace-expansion@v1.1.13...v5.0.7)

Updates `@vscode/vsce` from 3.9.1 to 3.9.2
- [Release notes](https://github.com/Microsoft/vsce/releases)
- [Commits](microsoft/vscode-vsce@v3.9.1...v3.9.2)

---
updated-dependencies:
- dependency-name: brace-expansion
  dependency-version: 5.0.7
  dependency-type: indirect
- dependency-name: "@vscode/vsce"
  dependency-version: 3.9.2
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix portable ps command for remote process picker (#14592)

* Fix portable remote process ps command

* Bump fast-uri from 3.1.2 to 3.1.4 in /Themes (#14593)

Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.2 to 3.1.4.
- [Release notes](https://github.com/fastify/fast-uri/releases)
- [Commits](fastify/fast-uri@v3.1.2...v3.1.4)

---
updated-dependencies:
- dependency-name: fast-uri
  dependency-version: 3.1.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump linkify-it from 5.0.1 to 5.0.2 in /ExtensionPack (#14594)

Bumps [linkify-it](https://github.com/markdown-it/linkify-it) from 5.0.1 to 5.0.2.
- [Changelog](https://github.com/markdown-it/linkify-it/blob/master/CHANGELOG.md)
- [Commits](markdown-it/linkify-it@5.0.1...5.0.2)

---
updated-dependencies:
- dependency-name: linkify-it
  dependency-version: 5.0.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump linkify-it from 5.0.1 to 5.0.2 in /Extension (#14596)

Bumps [linkify-it](https://github.com/markdown-it/linkify-it) from 5.0.1 to 5.0.2.
- [Changelog](https://github.com/markdown-it/linkify-it/blob/master/CHANGELOG.md)
- [Commits](markdown-it/linkify-it@5.0.1...5.0.2)

---
updated-dependencies:
- dependency-name: linkify-it
  dependency-version: 5.0.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sean McManus <seanmcm@microsoft.com>

* Bump js-yaml from 4.2.0 to 4.3.0 in /Extension (#14597)

Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.2.0 to 4.3.0.
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](nodeca/js-yaml@4.2.0...4.3.0)

---
updated-dependencies:
- dependency-name: js-yaml
  dependency-version: 4.3.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sean McManus <seanmcm@microsoft.com>

* Update dependencies. (#14598)

* Fix build tools walkthrough for VS 2026. (#14589)

* Bump fast-uri from 3.1.3 to 3.1.4 in /ExtensionPack (#14599)

Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.3 to 3.1.4.
- [Release notes](https://github.com/fastify/fast-uri/releases)
- [Commits](fastify/fast-uri@v3.1.3...v3.1.4)

---
updated-dependencies:
- dependency-name: fast-uri
  dependency-version: 3.1.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update dependencies again. (#14600)

* Update .gitignore for installed bin files. (#14606)

* Skip terminate_handler( frames. (#14609)

* Fix si_code=, si_addr=undefined. (#14608)

* Fix si_code=, si_addr=undefined.

* Update brace-expansion. (#14610)

* Update ThirdPartyNotices.txt (#14611)

* Update ThirdPartyNotices.txt

* Normalize JSON trailing newlines. (#14579)

* Unify json newlines.

* Use PowerShell call operator when shell integration is unavailable (#14585)

"Run C/C++ File" builds the command with buildShellCommandLine and sends
it via sendText when the terminal has no shell integration. That path
quotes a program path containing spaces but never prepends the call
operator, so PowerShell evaluates the quoted path as a string literal and
echoes it instead of running the program.

The shell-integration path already handles this, so extract its PowerShell
detection into isPowerShellTerminal() and reuse it in the sendText path.

Closes #14583

Co-authored-by: Sean McManus <seanmcm@microsoft.com>
Co-authored-by: Bob Brown <bobbrow@users.noreply.github.com>

* Update changelog for 1.33.5. (#14613)

* Update changelog for 1.33.5.
* Update version to 1.33.5.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Colen Garoutte-Carson <49173979+Colengms@users.noreply.github.com>
Co-authored-by: Glen Chung <105310954+kuchungmsft@users.noreply.github.com>
Co-authored-by: Bob Brown <bobbrow@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: HuzaifaAbdulRehman <143286445+HuzaifaAbdulRehman@users.noreply.github.com>
Co-authored-by: Weverton Guedes <146861752+owevertonguedes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants