Add emission EDF to Metashade Standard Surface - #46
Open
ppenenko wants to merge 2 commits into
Open
Conversation
Update Metashade submodule to include emission EDF wiring in the thin nodegraph. Regenerate all 6 shader dumps which now include mx_uniform_edf and the emission contribution. Signed-off-by: Pavlo Penenko <pavlo.penenko@autodesk.com>
There was a problem hiding this comment.
Pull request overview
This pull request updates the Metashade-generated Standard Surface reference pixel shaders to include an emission EDF path, aligning the thin nodegraph’s emission wiring with the reference Standard Surface emission behavior (without coat interaction), and refreshes the corresponding render shader baselines.
Changes:
- Introduce
mx_uniform_edfinto the generated shader dumps. - Compute
emission_color * emissionand add the resulting emission contribution to the surface output. - Regenerate the 6 Standard Surface baseline GLSL pixel shaders under
contrib/tests/metashade_ref/....
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| contrib/tests/metashade_ref/renders/standard_surface/aswf/standard_surface_thin_film/ThinFilm_ps.glsl | Adds mx_uniform_edf and wires emission contribution into the Standard Surface output. |
| contrib/tests/metashade_ref/renders/standard_surface/aswf/standard_surface_plastic/Plastic_ps.glsl | Adds mx_uniform_edf and wires emission contribution into the Standard Surface output. |
| contrib/tests/metashade_ref/renders/standard_surface/aswf/standard_surface_greysphere/Greysphere_ps.glsl | Adds mx_uniform_edf and wires emission contribution into the Standard Surface output. |
| contrib/tests/metashade_ref/renders/standard_surface/aswf/standard_surface_gold/Gold_ps.glsl | Adds mx_uniform_edf and wires emission contribution into the Standard Surface output. |
| contrib/tests/metashade_ref/renders/standard_surface/aswf/standard_surface_default/Default_ps.glsl | Adds mx_uniform_edf and wires emission contribution into the Standard Surface output. |
| contrib/tests/metashade_ref/renders/standard_surface/aswf/standard_surface_chrome/Chrome_ps.glsl | Adds mx_uniform_edf and wires emission contribution into the Standard Surface output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Pavlo Penenko <pavlo.penenko@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emission_color * emission->uniform_edf->surfaceconstructor'sedfinput in the thin nodegraph (Add emission EDF to Standard Surface thin nodegraph metashade#213).NG_standard_surface_surfaceshader_100emission path (without coat interaction).mx_uniform_edfand the emission contribution.Note: None of the existing Standard Surface example materials set non-zero
emission, so the emission path is not directly exercised by the current render tests. It is, however, verified structurally via the regenerated shader dumps.Test plan
mx_uniform_edfand emission wiring