Skip to content

Add emission EDF to Metashade Standard Surface - #46

Open
ppenenko wants to merge 2 commits into
metashade/devfrom
metashade/emission
Open

Add emission EDF to Metashade Standard Surface#46
ppenenko wants to merge 2 commits into
metashade/devfrom
metashade/emission

Conversation

@ppenenko

Copy link
Copy Markdown
Member

Summary

  • Update Metashade submodule: wire emission_color * emission -> uniform_edf -> surface constructor's edf input in the thin nodegraph (Add emission EDF to Standard Surface thin nodegraph metashade#213).
  • Matches the reference NG_standard_surface_surfaceshader_100 emission path (without coat interaction).
  • Regenerate all 6 render shader baselines which now include mx_uniform_edf and the emission contribution.

Note: None of the existing Standard Surface example materials set non-zero emission, so the emission path is not directly exercised by the current render tests. It is, however, verified structurally via the regenerated shader dumps.

Test plan

  • All existing render tests pass (81 passed, 172 subtests)
  • Shader dumps include mx_uniform_edf and emission wiring
  • CI passes

Update Metashade submodule to include emission EDF wiring in the thin
nodegraph.  Regenerate all 6 shader dumps which now include
mx_uniform_edf and the emission contribution.

Signed-off-by: Pavlo Penenko <pavlo.penenko@autodesk.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the Metashade-generated Standard Surface reference pixel shaders to include an emission EDF path, aligning the thin nodegraph’s emission wiring with the reference Standard Surface emission behavior (without coat interaction), and refreshes the corresponding render shader baselines.

Changes:

  • Introduce mx_uniform_edf into the generated shader dumps.
  • Compute emission_color * emission and add the resulting emission contribution to the surface output.
  • Regenerate the 6 Standard Surface baseline GLSL pixel shaders under contrib/tests/metashade_ref/....

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
contrib/tests/metashade_ref/renders/standard_surface/aswf/standard_surface_thin_film/ThinFilm_ps.glsl Adds mx_uniform_edf and wires emission contribution into the Standard Surface output.
contrib/tests/metashade_ref/renders/standard_surface/aswf/standard_surface_plastic/Plastic_ps.glsl Adds mx_uniform_edf and wires emission contribution into the Standard Surface output.
contrib/tests/metashade_ref/renders/standard_surface/aswf/standard_surface_greysphere/Greysphere_ps.glsl Adds mx_uniform_edf and wires emission contribution into the Standard Surface output.
contrib/tests/metashade_ref/renders/standard_surface/aswf/standard_surface_gold/Gold_ps.glsl Adds mx_uniform_edf and wires emission contribution into the Standard Surface output.
contrib/tests/metashade_ref/renders/standard_surface/aswf/standard_surface_default/Default_ps.glsl Adds mx_uniform_edf and wires emission contribution into the Standard Surface output.
contrib/tests/metashade_ref/renders/standard_surface/aswf/standard_surface_chrome/Chrome_ps.glsl Adds mx_uniform_edf and wires emission contribution into the Standard Surface output.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Signed-off-by: Pavlo Penenko <pavlo.penenko@autodesk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants