fix(cli): exit with non-zero code for unknown flags - #252
Open
prathamesh04 wants to merge 1 commit into
Open
Conversation
The CLI was exiting with code 0 when unknown flags were passed, breaking CI pipelines and shell scripts that check exit codes. Changes: - Add UnknownFlag error code to ErrorCode enum - Add optional exitCode parameter to printHelp() - Exit with ErrorCode.UnknownFlag when unknown flags are detected - Keep exit code 0 for explicit --help flag Fixes metacall#212
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CLI was exiting with code 0 when unknown flags were passed, breaking CI pipelines and shell scripts that check exit codes.
Fixes #212
Changes
UnknownFlagerror code toErrorCodeenumexitCodeparameter toprintHelp()ErrorCode.UnknownFlagwhen unknown flags are detected--helpflagChecklist
npm run build)npm run lint)