You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ip-address transitive dependency bumped from 10.2.0 to 10.4.0
Skipped (out of scope): pnpm-lock.yaml (lockfile changes reviewed only for the ip-address bump context)
Findings
⚠️ Low — Changelog-check now runs on fork PRs
File:.github/workflows/BuildJobs.yml line 69 Note: The removed condition github.event.pull_request.head.repo.full_name == 'mendix/web-widgets' previously ensured the changelog step only ran on PRs from the main repo. Without it, the step will also run on fork PRs. Since it runs in the check job (which runs on pull_request from main), fork PRs generally have limited access to secrets, but the step itself (pnpm run -w check-changelogs) reads BASE_SHA/HEAD_SHA from the event — those are available to fork PRs. This is probably the intended change (e.g. to enforce changelog checks on community PRs too), but consider documenting the intent in a comment so reviewers don't re-add the guard in the future.
⚠️ Low — minimumMXVersion bump has no CHANGELOG entry
File:packages/pluggableWidgets/image-cropper-web/package.json line 20 Note: Raising minimumMXVersion from 10.21.0 to 11.12.0 is a breaking change for any user still on Mx 10.x. The current CHANGELOG only has the [1.0.0] initial release entry under [Unreleased] — there is no new entry recording this compatibility change. Consider adding a brief entry (e.g. under ### Changed: Raised minimum Mendix version to 11.12.0) so downstream consumers are informed. Run pnpm -w changelog to scaffold the entry.
Positives
The ip-address bump from 10.2.0 → 10.4.0 addresses a known transitive vulnerability in express-rate-limit cleanly, with no manual override traces left in package.json.
All action references in the workflow remain SHA-pinned with version comments — the edit preserves that convention.
The condition change is minimal and surgical; it doesn't touch any surrounding logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.