Skip to content

[MOO-2399]: fix nc/nmr changes during build - #583

Open
SrirangK wants to merge 1 commit into
mx/11.12.xfrom
moo/MOO-2399/fix-module-changes-during-run
Open

[MOO-2399]: fix nc/nmr changes during build#583
SrirangK wants to merge 1 commit into
mx/11.12.xfrom
moo/MOO-2399/fix-module-changes-during-run

Conversation

@SrirangK

@SrirangK SrirangK commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Contains unit tests ❌
  • Contains breaking changes ✅
  • Compatible with: MX 8, 9, 10
  • Did you update version and changelog? ❌
  • PR title properly formatted ([XX-000]: description)? ✅
  • Works in Android ✅ ❌
  • Works in iOS ✅ ❌
  • Works in Tablet ✅ ❌

Feature specific

  • Comply with designs ✅ ❌
  • Comply with PM's requirements ✅ ❌

Please remove unnecessary emojis and sections and this comment before proceeding

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

...

Relevant changes

Please add a high level explanation of what was changed and how the initial problem was solved

What should be covered while testing?

...

Extra comments (optional)

Please add extra comments or delete the section if not required

@SrirangK
SrirangK requested a review from a team as a code owner August 3, 2026 06:27
@MxKevinBeqo

Copy link
Copy Markdown
Contributor

Hey @SrirangK ,
I feel like this is too much of a manual work, which should not be handled at this level. Basically at this point, it seems we are 'reversing the transpilation' of TS -> JS.
I can imagine that formatting changes in the future might have us going back and maintaining this script.

Looking at how this issue was observed in 11.11, we can take a look at how the files looked like for 10.24. Ideally, as a conclusion we should look for the cause and not to fix the symptom e.g. perhaps some rollup changes on Mx 11 affected the modules js files which should be excluded; perhaps the starter app is being created with 'not-properly/fully transpiled' code etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants