👷 [#771] Change Bencher threshold test to use IQR#783
Open
stevenbal wants to merge 3 commits into
Open
Conversation
comparing to just the previous result can lead to false alarms because of noise caused by running on non-dedicated action runners. With the changed parameters more history is taken into account and IQR should be less affected by outliers
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #783 +/- ##
=======================================
Coverage 86.77% 86.77%
=======================================
Files 145 145
Lines 3161 3161
Branches 253 253
=======================================
Hits 2743 2743
Misses 370 370
Partials 48 48 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
CharString
approved these changes
Jul 10, 2026
CharString
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Maybe that little iqr calculation needs find somewhere else to live... Preferably a view on the Bencher website.🙂 It was a quick one of, but it felt wrong to just keep it around on my machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #771
Changes
Checklist
Commit hygiene
Architectural design record