variants of {sup,inf}_le - #2021
Open
affeldt-aist wants to merge 1 commit into
Open
Conversation
affeldt-aist
added
the
enhancement ✨
Contributor
|
Can I add 2 more lemmas that I use for my work ? I will pr them on top of yours |
Member
Author
|
TODO: merge this PR by Arthur affeldt-aist#46 |
affeldt-aist
force-pushed
the
reals_20260708
branch
from
July 28, 2026 15:05
3a2f1b2 to
1fb6e89
Compare
Member
Author
They look ok to me though a link to where they are used would have been helpful to review. |
affeldt-aist
force-pushed
the
reals_20260708
branch
from
July 30, 2026 00:05
1fb6e89 to
8e6389e
Compare
Member
Author
|
@holgerthies do you think the lemmas added by @Brixfoly are ok? |
- le_supP and gt_sup Co-authored-by: Marie Kerjean <marie.kerjean@cnrs.fr> Co-authored-by: adjevahi <arthur.djevahirdjian@ens-lyon.fr>
affeldt-aist
force-pushed
the
reals_20260708
branch
from
July 31, 2026 04:05
8e6389e to
d4ba3a2
Compare
Member
Author
|
Since the first lemmas we added come from an experiment and find their use already in master, and since the later lemmas were actually used, I am thinking of merging this one in the interest of the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Checklist
CHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers