Fix background music on Windows - #114
Open
wingkuitsoi wants to merge 2 commits into
Open
Conversation
luiges90
requested changes
Jun 19, 2026
luiges90
left a comment
luiges90
left a comment
Owner
There was a problem hiding this comment.
This change may break old versions relying on certain file extensions. Audio file extensions are also fairly unreliable. I recommend accepting all ogg, mp3 and wav formats and use try-catch to skip files that cannot be read.
Contributor
Author
|
Change based on suggestions. |
wingkuitsoi
marked this pull request as draft
June 20, 2026 02:54
wingkuitsoi
marked this pull request as ready for review
June 20, 2026 02:54
luiges90
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The game is missing background music when running on a local Windows computer.
Changes: