Restore pump status in Nightscout device status uploads#2
Closed
bjorkert wants to merge 1 commit into
Closed
Conversation
Populate pumpManagerStatus, pumpStatusHighlight, cgmManagerStatus, and lastReservoirValue on the dosing decisions NightscoutService uploads, so the devicestatus pump object (clock, reservoir, model, ...) is no longer omitted.
Author
|
Moving this to LoopKit#2460, since LoopKit/Loop is now the next-dev source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next-dev rewrite of
LoopDataManagerdropped the code that attached device status to the dosing decisions Nightscout uploads. As a resultdevicestatusis missing its entirepumpobject —clock,reservoir,model, and so on — which downstream tools (Nightscout, LoopFollow) rely on. On current dev these fields were populated inupdate(for:).NightscoutServiceKit'sStoredDosingDecision.pumpStatusreturnsnilunlesspumpManagerStatusis set, so with these fields unset the wholepumpblock is omitted from every upload.This restores the same fields dev set, on the decisions NightscoutService actually uploads:
updateRemoteRecommendation(routine):pumpManagerStatus,pumpStatusHighlight,cgmManagerStatus,lastReservoirValuepumpManagerStatus,cgmManagerStatus(lastReservoirValuewas already set)DeliveryDelegategainspumpManagerStatus,pumpStatusHighlight, andcgmManagerStatus;DeviceDataManageralready provides all three.