chore(e2e): deflake known rare console error about CORS policy - #6917
Open
corneliusroemer wants to merge 1 commit into
Open
chore(e2e): deflake known rare console error about CORS policy#6917corneliusroemer wants to merge 1 commit into
corneliusroemer wants to merge 1 commit into
Conversation
Rare console errors that are not due to clear underlying problems. Possibly related to LAPIS or SILO dropping requests when switching to new dataVersion. Console errors like this will no longer fail reducing flakiness: ``` Error: Unexpected console error: Access to XMLHttpRequest at 'http://10.1.1.126:8080/ebola-sudan/sample/aggregated' from origin 'http://localhost:3000' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. ```
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce Playwright integration-test flakiness by treating a specific rare CORS-related console error as “harmless”, so it no longer fails tests when it occurs during runs.
Changes:
- Adds an additional substring to the console-warning filter allowlist so a known CORS console error doesn’t fail Chromium-based e2e tests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rare console errors that are not due to clear underlying problems. Possibly related to LAPIS or SILO dropping requests when switching to new dataVersion.
Console errors like this will no longer fail reducing flakiness:
🚀 Preview: Add
previewlabel to enable