Ensure participant disconnects are synthesized after connection resume#1250
Open
lukasIO wants to merge 4 commits into
Open
Ensure participant disconnects are synthesized after connection resume#1250lukasIO wants to merge 4 commits into
lukasIO wants to merge 4 commits into
Conversation
Contributor
Changeset ✓This PR includes a changeset covering all affected packages:
|
ladvoc
reviewed
Jul 14, 2026
| ); | ||
| } | ||
| proto::signal_response::Message::Update(mut update) => { | ||
| #[cfg(feature = "__lk-e2e-test")] |
Contributor
There was a problem hiding this comment.
question: Why is this gated behind the E2E test feature?
Contributor
Author
There was a problem hiding this comment.
this is used/injected in e2e tests only as faulty behaviour during a signal disconnect to ensure we can mimic losing/missing participant disconnect events after a resume.
lukasIO
marked this pull request as ready for review
July 15, 2026 10:54
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before you submit your PR
Make sure the following is true before submitting your PR:
PR description
Describe the changes in this PR. Explain what the PR is meant to solve and how to reproduce the issue in the first place.
Breaking changes
If this PR introduces breaking changes, list them here and document the rationale for introducing such a change.
MSRV
If the PR modifies the crate's MSRV (Minimum Supported Rust Version), document it here.
Testing
Ideally, unit test the code you add, but ensure you're not repeating existing test cases. Use as many already written scaffolding, utilities as possible; write your own, when needed. If external services, APIs, tokens are required (e.g., running an LK server instance), provide the necessary information. Make sure your tests perform useful, context-aware assertions and do not simply emulate "happy paths".
Async
We want the project to be runtime-agnostic, so please reuse what's already in livekit-runtime and feel free to add anything missing. It's ok to use Tokio directly, when writing unit tests, if necessary. When testing, do not use artificial delays for the state to "catch up"; instead, respect the event flow and subscribe properly using channels or other mechanisms.