feat(workflows): expose humanAgentRoomName option on WarmTransferTask - #2056
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 7f403da The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
davidzhao
approved these changes
Jul 18, 2026
Member
|
I'm wondering if the name should just be room_name? |
Per review feedback on #2056. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
WarmTransferTaskhardcodes the human-agent briefing room name as`${callerRoom.name}-human-agent`and relies on implicit room creation when the transfer agent connects. That makes it impossible to configure the briefing room ahead of time — most notably to attach a RoomComposite egress so the agent ↔ human-agent consultation leg of a warm transfer gets recorded (the caller-room leg is already recordable with a normal room egress; the consult room was not).Changes
humanAgentRoomNameoption toWarmTransferTaskOptions(defaults to the existing`${callerRoom.name}-human-agent`, so behavior is unchanged when unset).RoomServiceClient.createRoomwith anegressrequest); the transfer agent then joins the pre-configured room instead of implicitly creating one with project defaults.resolveHumanAgentRoomNamehelper (module-level export for tests; not added to the package index).createWarmTransferTask; an override equal to the caller room name rejected at dial time.room.connect,createSipParticipant,deleteRoomOnClose, and all cancellation/teardown paths are untouched. The JSDoc documents that the room is deleted when the transfer completes/fails/cancels (which also ends any attached egress).Example
Testing
agents/src/workflows/warm_transfer.test.ts: default name resolution, override, same-name-as-caller rejection, empty-string rejection (4/4 passing).agents/srcsuite: 1282 passed / 5 skipped; typecheck, build, and lint on touched files clean.@livekit/agents: patch).