Add ability to have multiple host ports - #253
Open
Mr-Bossman wants to merge 3 commits into
Open
Conversation
igaw
reviewed
Jul 27, 2026
kawasaki
requested changes
Jul 30, 2026
kawasaki
left a comment
kawasaki
left a comment
Collaborator
There was a problem hiding this comment.
Hi @Mr-Bossman thank you for the PR. Overall, four out of the three commits look good. I'm not so sure about the first commit, "nvme: Delete lports in _nvmet_target_cleanup". Its commit message says that _nvmet_target_cleanup() is called when Ctrl-C is typed, but my understanding is that _cleanup_nvmet() is called when Ctrl-C is typed.
Other three commits looks valid. Please find some minor comments I made for them, and see if they make sense for you.
I have not yet done trail test runs. Will do later. Thanks!
Mr-Bossman
force-pushed
the
dev/jesse/nvme_features
branch
4 times, most recently
from
July 30, 2026 15:24
19f8144 to
6ecd543
Compare
Add `_nvmet_target_add_ports` to allow for more ports to be added after `_nvmet_target_setup` has been called. Signed-off-by: Jesse Taube <jtaubepe@redhat.com>
Currently, the nvme tests only support a single host port. This patch adds the ability to have multiple host ports, which will more accuratly reflect a real-world multipath scenario. Signed-off-by: Jesse Taube <jtaubepe@redhat.com>
If cscope and ctags are installed create the databases needed to browse these shell scripts with cscope/ctags. Signed-off-by: John Meneghini <jmeneghi@redhat.com>
Mr-Bossman
force-pushed
the
dev/jesse/nvme_features
branch
from
July 31, 2026 14:30
6ecd543 to
2acedec
Compare
Author
|
@kawasaki I dropped the "nvme: Delete lports in _nvmet_target_cleanup" commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add various features namely the ability to have multiple host ports
This will be used in my upcoming PR for testing nvme marginal support.
All the commits are independent of one-anther, if anyone thinks its a good idea
to split them into multiple PRs I can .
makefile: Add rules to generate ctags
nvme: Add ability to have multiple host ports
nvme: Add _nvmet_target_add_ports