lnwallet/btcwallet: skip 2-hour tip-staleness check on regtest/simnet - #11002
Open
ZZiigguurraatt wants to merge 1 commit into
Open
lnwallet/btcwallet: skip 2-hour tip-staleness check on regtest/simnet#11002ZZiigguurraatt wants to merge 1 commit into
ZZiigguurraatt wants to merge 1 commit into
Conversation
IsSynced rejected "synced" status whenever the best block header timestamp was more than 2 hours in the past. On regtest and simnet blocks are only mined on demand, so an idle chain would drive the tip timestamp past that window and report synced_to_chain=false, and could block the startup sync loop indefinitely. Skip the staleness check on local networks (regtest via wire.TestNet, simnet via wire.SimNet); mainnet and testnet3/testnet4 are unaffected. Also rename the misleading minus24Hours variable to minus2Hours. Add TestIsSyncedStaleTip covering the skip on regtest/simnet, the still-enforced check on mainnet, and a testnet3 guard case ensuring the skip does not accidentally match real testnet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsSynced rejected "synced" status whenever the best block header timestamp was more than 2 hours in the past. On regtest and simnet blocks are only mined on demand, so an idle chain would drive the tip timestamp past that window and report synced_to_chain=false, and could block the startup sync loop indefinitely.
Skip the staleness check on local networks (regtest via wire.TestNet, simnet via wire.SimNet); mainnet and testnet3/testnet4 are unaffected. Also rename the misleading minus24Hours variable to minus2Hours.
Add TestIsSyncedStaleTip covering the skip on regtest/simnet, the still-enforced check on mainnet, and a testnet3 guard case ensuring the skip does not accidentally match real testnet.
Fixes #11004