Skip to content

fix: update game page icons for clarity (#3484) - #3491

Open
assassinaj602 wants to merge 5 commits into
lichess-org:mainfrom
assassinaj602:fix-issue-3484
Open

fix: update game page icons for clarity (#3484)#3491
assassinaj602 wants to merge 5 commits into
lichess-org:mainfrom
assassinaj602:fix-issue-3484

Conversation

@assassinaj602

Copy link
Copy Markdown
Contributor

Replaced chat bubble icon with clearer speech bubble icon. Replaced flag icon with more distinct flag_fill icon.

- Replaced chat bubble icon with clearer speech bubble icon
- Replaced flag icon with more distinct flag_fill icon
- Makes icons more intuitive for users

Fixes lichess-org#3484
@veloce

veloce commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Thanks. Can you post a screenshot please?

@assassinaj602

Copy link
Copy Markdown
Contributor Author

@veloce Thanks for the review! Unfortunately I'm having trouble testing online games (need to be online and have an opponent).

The changes are straightforward icon swaps:

  • Chat icon: CupertinoIcons.chat_bubbleCupertinoIcons.speech_bubble
  • Flag icon: CupertinoIcons.flagCupertinoIcons.flag_fill

Both are in the game screen's bottom bar and only appear in online games. You can verify the changes in the code at:

  • lib/src/view/game/game_screen.dart
  • lib/src/view/game/game_common_widgets.dart

The functionality is unchanged - just swapping for more recognizable icons. Let me know if you need anything else!

@assassinaj602

assassinaj602 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

@veloce Thanks for the review! Unfortunately I'm having trouble testing online games (need to be online and have an opponent).

The changes are straightforward icon swaps:

  • Chat icon: CupertinoIcons.chat_bubbleCupertinoIcons.speech_bubble

  • Flag icon: CupertinoIcons.flagCupertinoIcons.flag_fill

Both are in the game screen's bottom bar and only appear in online games. You can verify the changes in the code at:

  • lib/src/view/game/game_screen.dart

  • lib/src/view/game/game_common_widgets.dart

The functionality is unchanged - just swapping for more recognizable icons. Let me know if you need anything else!

Can you share a screenshot?

@assassinaj602

Copy link
Copy Markdown
Contributor Author

@ijm8710 screenshot about what?

@ijm8710

ijm8710 commented Jul 26, 2026

Copy link
Copy Markdown

@ijm8710 screenshot about what?

Of the new icons

@assassinaj602

Copy link
Copy Markdown
Contributor Author

@ijm8710 screenshot about what?

Of the new icons

@ijm8710 that's what I am saying for Chat screen icon I have to play online to see it but there are not much players online whom I can play with

@veloce

veloce commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@veloce Thanks for the review! Unfortunately I'm having trouble testing online games (need to be online and have an opponent).

If you really want to dev on this project you should be able to do that.
You can create 2 accounts on lichess.dev, then you can login in the app, login in the browser and challenge one of the user. It's quite simple.

More work but you could also setup a local Lila and use the db seed to populate users: https://github.com/lichess-org/lila/wiki

assassinaj602 added a commit to assassinaj602/mobile that referenced this pull request Jul 27, 2026
@assassinaj602

Copy link
Copy Markdown
Contributor Author

@veloce Thank you for the honest feedback and for the guidance on setting up a development environment.

You're right – I should have taken the initiative to properly test this change instead of relying on code review alone. I appreciate you pointing me to the lichess.dev and local Lila setup options.

I will now:

Set up two accounts on lichess.dev to properly test the online game interface.

Verify that both the chat and flag icons appear correctly in a real game scenario.

Post a screenshot of the updated UI once I've confirmed the changes.

I'll update this PR with the screenshot as soon as I have it working. Thanks for your patience and for the helpful resources.

@assassinaj602

Copy link
Copy Markdown
Contributor Author

I’ve updated the PR with the latest changes:

Updated the flag icons to use CupertinoIcons.flag_fill across game and offline‑computer screens.
Adjusted the chat icon to CupertinoIcons.chat_bubble_text to match the design guidelines.

I’m attaching a screenshot of the updated UI (showing the new flag and chat icons) for quick verification.

Thanks for reviewing! Let me know if anything else is needed.
screenshot

@ijm8710

ijm8710 commented Jul 27, 2026

Copy link
Copy Markdown

As someone who has felt this change was not needed in the first place, the suggested replacements in this proposed pr are absolutely not an improvement in my opinion and make the styling look more inconsistent/confusing.

If any change is accepted (and personally I feel it's fine as is, especially the resign button), perhaps rounding out the message icon slightly would be the only thing that makes sense but even then it should keep the lack of fill and ensure design consistency.

potential new chat bubble design although current is preferred

@assassinaj602

Copy link
Copy Markdown
Contributor Author

@ijm8710 Thanks for your feedback! I understand your perspective on keeping the icons consistent without fill.

My goal with this PR was to make the icons more recognizable based on the issue description (#3484) which mentioned users found them confusing.

That said, I'm happy to defer to the maintainers' judgment. Let's wait for @veloce's review and see if they want any adjustments.

If we end up going with a different approach (like rounding the message icon instead), I'm happy to make those changes.

Thanks for taking the time to share your thoughts!

@assassinaj602

assassinaj602 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@veloce Did not heard back from you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants