fix: update game page icons for clarity (#3484) - #3491
Conversation
- Replaced chat bubble icon with clearer speech bubble icon - Replaced flag icon with more distinct flag_fill icon - Makes icons more intuitive for users Fixes lichess-org#3484
|
Thanks. Can you post a screenshot please? |
|
@veloce Thanks for the review! Unfortunately I'm having trouble testing online games (need to be online and have an opponent). The changes are straightforward icon swaps:
Both are in the game screen's bottom bar and only appear in online games. You can verify the changes in the code at:
The functionality is unchanged - just swapping for more recognizable icons. Let me know if you need anything else! |
|
|
@ijm8710 screenshot about what? |
Of the new icons |
If you really want to dev on this project you should be able to do that. More work but you could also setup a local Lila and use the db seed to populate users: https://github.com/lichess-org/lila/wiki |
578120e to
6207bec
Compare
|
@veloce Thank you for the honest feedback and for the guidance on setting up a development environment. You're right – I should have taken the initiative to properly test this change instead of relying on code review alone. I appreciate you pointing me to the lichess.dev and local Lila setup options. I will now: Set up two accounts on lichess.dev to properly test the online game interface. Verify that both the chat and flag icons appear correctly in a real game scenario. Post a screenshot of the updated UI once I've confirmed the changes. I'll update this PR with the screenshot as soon as I have it working. Thanks for your patience and for the helpful resources. |
4545f94 to
097fc9d
Compare
|
As someone who has felt this change was not needed in the first place, the suggested replacements in this proposed pr are absolutely not an improvement in my opinion and make the styling look more inconsistent/confusing. If any change is accepted (and personally I feel it's fine as is, especially the resign button), perhaps rounding out the message icon slightly would be the only thing that makes sense but even then it should keep the lack of fill and ensure design consistency. potential new chat bubble design although current is preferred |
|
@ijm8710 Thanks for your feedback! I understand your perspective on keeping the icons consistent without fill. My goal with this PR was to make the icons more recognizable based on the issue description (#3484) which mentioned users found them confusing. That said, I'm happy to defer to the maintainers' judgment. Let's wait for @veloce's review and see if they want any adjustments. If we end up going with a different approach (like rounding the message icon instead), I'm happy to make those changes. Thanks for taking the time to share your thoughts! |
|
@veloce Did not heard back from you |

Replaced chat bubble icon with clearer speech bubble icon. Replaced flag icon with more distinct flag_fill icon.