doc: drop internal-lemma references from repeatM docstrings - #14436
Merged
Conversation
This PR removes references to the unfolding lemma from the `repeatM` docstrings and moves that lemma into the `repeatM.Internal` namespace. The lemma `repeatM_eq_of_monadTail` becomes `repeatM.Internal.eq_of_monadTail`, which places it in an internal namespace and lets the `coreInternal.internalModule` linter run unsuppressed on `Init.Internal.Order.While`. Nesting under `repeatM` rather than a top-level `Internal` avoids shadowing the `Internal` namespaces that other modules open.
sgraf812
force-pushed
the
sg/repeatM-internal-docstring
branch
from
July 17, 2026 15:51
e287b80 to
e75d43b
Compare
sgraf812
marked this pull request as ready for review
July 17, 2026 16:01
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
robsimmons
pushed a commit
that referenced
this pull request
Jul 29, 2026
This PR removes references to the unfolding lemma from the `repeatM` docstrings and moves that lemma into the `repeatM.Internal` namespace. The lemma `repeatM_eq_of_monadTail` becomes `repeatM.Internal.eq_of_monadTail`, which places it in an internal namespace and lets the `coreInternal.internalModule` linter run unsuppressed on `Init.Internal.Order.While`. Nesting under `repeatM` rather than a top-level `Internal` avoids shadowing the `Internal` namespaces that other modules open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes references to the unfolding lemma from the
repeatMdocstrings and moves that lemma into therepeatM.Internalnamespace.The lemma
repeatM_eq_of_monadTailbecomesrepeatM.Internal.eq_of_monadTail, which places it in an internal namespace and lets thecoreInternal.internalModulelinter run unsuppressed onInit.Internal.Order.While. Nesting underrepeatMrather than a top-levelInternalavoids shadowing theInternalnamespaces that other modules open.