feat(PFunctor): redefine PFunctor.FreeM in terms of PFunctor.W#731
Open
dtumad wants to merge 2 commits into
Open
feat(PFunctor): redefine PFunctor.FreeM in terms of PFunctor.W#731dtumad wants to merge 2 commits into
PFunctor.FreeM in terms of PFunctor.W#731dtumad wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
PFunctor.FreeM P AandPFunctor.W (P.add (.const A))are equivalent but not definitionally equal, so proofs about one can't be translated over to the other automatically, they need to factor through aFreeM.toWandFreeM.ofWdefinition.This PR redefines
PFunctor.FreeMso that they are the same by construction. Case analysis lemmas are tagged with@[cases_eliminator]and@[induction_eliminator]so those tactics don't break (although manual pattern matching does). It also adds definitions ofPFunctor.monomialandPFunctor.addthat are used in the definition, and a short test file checking thatcasesandinductiondon't break.Definitions in
Basic.leanmostly come from downstream PolyFun library.