chore(setup): add SDK/project detection library - #749
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
| if result := detectDotnet(dir); result != nil { | ||
| return result, nil | ||
| } | ||
| return nil, errors.New("could not detect project language from directory; try specifying --sdk-id manually") |
There was a problem hiding this comment.
"could not detect project language from directory")
Should probably mean "Hey, here's a link to the docs and a blurb about how to do this install manually"
If we're doing a hybrid approach to setup, then we should definitely
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 5 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3a1d4dd. Configure here.
| return &DetectResult{ | ||
| Language: "Java", | ||
| PackageManager: "gradle", | ||
| SDKID: "android-client-sdk", |
There was a problem hiding this comment.
Wrong Android SDK identifier
Medium Severity
Detected and listed Android SDK ID is android-client-sdk, but every other ID in KnownSDKs matches the established SDK IDs used by sdk_instructions and quickstart (where Android is android from android.md). This mismatch will fail lookups against sdkmeta or instruction files when setup is wired up.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 3a1d4dd. Configure here.
| "src/index.ts", "src/index.js", | ||
| "pages/index.tsx", "pages/index.ts", "pages/index.js", | ||
| "index.js", | ||
| })), |
There was a problem hiding this comment.
Next.js entry points outdated
Medium Severity
Next.js entry-point candidates only cover Pages Router paths (pages/index.*, src/index.*) and fall back to index.js. App Router defaults from create-next-app use app/page.tsx / src/app/page.tsx, so detection suggests a nonexistent file for the common modern layout.
Reviewed by Cursor Bugbot for commit 3a1d4dd. Configure here.
| PackageManager: "gradle", | ||
| SDKID: "android-client-sdk", | ||
| EntryPoint: filepath.Join(dir, "app/src/main/java/MainActivity.java"), | ||
| } |
There was a problem hiding this comment.
Android entry path mismatch
Medium Severity
Android detection accepts manifests under either app/src/main/ or src/main/, but always returns the hardcoded entry point app/src/main/java/MainActivity.java. That path is wrong for the non-app/ layout and for typical Kotlin projects (even android.md references MainActivity.kt).
Reviewed by Cursor Bugbot for commit 3a1d4dd. Configure here.
| EntryPoint: filepath.Join(dir, firstExistingIn(dir, []string{ | ||
| "config.ru", "app.rb", "main.rb", | ||
| })), | ||
| } |
There was a problem hiding this comment.
Ruby package manager incorrect
Medium Severity
Ruby projects detected via Gemfile / Gemfile.lock report PackageManager as gem. Project-level installs for those indicators use Bundler (bundle add), not gem install. Node carefully distinguishes npm/yarn/pnpm/bun, so this value is inconsistent and will drive the wrong install command later.
Reviewed by Cursor Bugbot for commit 3a1d4dd. Configure here.
| "src/main.py", "manage.py", "app.py", "main.py", | ||
| })), | ||
| } | ||
| } |
There was a problem hiding this comment.
Poetry projects reported as pip
Low Severity
Any pyproject.toml (including Poetry, as in the unit test) always sets PackageManager to pip. Install tooling keyed off that field would run pip in Poetry-managed repos instead of poetry add, which is the wrong workflow for those projects.
Reviewed by Cursor Bugbot for commit 3a1d4dd. Configure here.
|
@ffantl-ld there is some valid bug bot issues flagged, wanted to make sure you were aware of them (either to fix now or punt on) |
| // firstExistingIn returns the first candidate that exists as a file in dir, | ||
| // or the last candidate if none exist (as a suggested path). | ||
| // Returns an empty string if candidates is empty. | ||
| func firstExistingIn(dir string, candidates []string) string { |
There was a problem hiding this comment.
suggestion: we should return whether the entry point actually exists so downstream steps can prompt the user instead
type DetectResult struct {
// ...
EntryPoint string `json:"entry_point"`
EntryPointExists bool `json:"entry_point_exists"`
}
// firstExistingIn returns the first candidate that exists in dir and true,
// or the last candidate and false as a suggestion if none exist.
func firstExistingIn(dir string, candidates []string) (string, bool) {
if len(candidates) == 0 {
return "", false
}
for _, c := range candidates {
if _, err := os.Stat(filepath.Join(dir, c)); err == nil {
return c, true
}
}
return candidates[len(candidates)-1], false
}Then the wizard can branch: exists → inject; doesn't → ask the user for the entry file (or show the snippet).
2 participants
Describe the solution you've provided
First layer of the guided
setupcommand: theinternal/setupdetection library. Inspects a project directory and identifies the language/package manager and the most likely LaunchDarkly SDK (Detectorinterface,FileDetector,KnownSDKs).Pure library with no consumer yet — the
setupcommand wires it up later in this stack.Related issues
Part of the
setup-ldfeature. Stacked PR — base issetup-ld.Requirements
Note
Low Risk
New read-only local filesystem logic with no CLI integration yet; mis-detection could suggest the wrong SDK later but does not touch auth or production paths in this PR.
Overview
Adds
internal/setup, a filesystem-based library for the upcoming guidedldcli setupflow. ADetectorinterface andFileDetectorscan a project directory and return language, package manager, framework (when applicable), a recommended LaunchDarklysdk_id, and a suggested entry-point path.Node detection parses
package.jsondependencies (including devDependencies), infers npm/yarn/pnpm/bun from lockfiles, and maps frameworks with explicit precedence (e.g. Next.js →node-server, React Native before React, browser stacks →js-client-sdk). Go, Python, Ruby, Java (vs Android viaAndroidManifest.xml), Swift, and .NET use conventional project markers. Unknown layouts error with guidance to pass--sdk-id.KnownSDKslists SDKs for manual selection;StubDetectorremains an unimplemented placeholder.Broad unit tests cover stacks, edge cases (malformed
package.json, entry-point fallbacks), and Ruby-specific fixtures.Reviewed by Cursor Bugbot for commit 3a1d4dd. Bugbot is set up for automated code reviews on this repo. Configure here.