Fixed 'DrupalExtension smoke' checkout failing for pull requests from forks. - #389
Conversation
… forks. The step set 'ref' to the head branch name while leaving 'repository' at the base repo, so a fork's branch was never found there and the fetch failed. The default checkout uses the pull request merge ref, which lives in the base repo and resolves for forks. The 'ref' override is no longer needed: the 'Add path repository' step always pins 'options.versions' for 'drupal/drupal-driver', and Composer's 'PathRepository' only consults the version guesser when no version is set, so the branch name never reaches it.
|
Warning Review limit reached
Next review available in: 6 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code coverage (threshold: 95%) Per-class coverage |
Summary
The
extensionjob ("DrupalExtension smoke") failed on every pull request from a fork: its "Checkout DrupalDriver" step setref:to the head branch name while leavingrepository:at the base repojhedstrom/DrupalDriver, where a fork's branch does not exist, sogit fetchmatched nothing and exited 1 (observed on PR #387, branchlegacyDrushfrom forkptmkenny/DrupalDriver). Theref:override was no longer needed: the "Add path repository for DrupalDriver" step always pinsoptions.versionsfordrupal/drupal-driver, and Composer'sPathRepository::initialize()only calls the version guesser - the only code path needing a branch name - when no version is set, so it never runs; the only remaining git call computesdist.referencefromHEAD, which works fine on a detached HEAD. Removingref:restores the default checkout of the PR merge ref, which lives in the base repo and resolves for forks, and brings this job in line with thelintandtestsjobs, which already test the merge result.Changes
.github/workflows/ci.yml: removed theref: ${{ github.head_ref || github.ref_name }}override and its explanatory comment from theextensionjob's "Checkout DrupalDriver" step, leaving the step to check outactions/checkout@v6's default ref.Before / After