Fix #96 - Don't escape the ES operator characters that archive.org rejects#97
Merged
Conversation
…jects #70 backslash-escaped the full Lucene special set in non-exactMatch values, but archive.org's Elasticsearch backend returns a backend error for the escaped operators (`\-`, `\+`, `\&`, `\|`, `\"`). `-` is in nearly every etree recording identifier, so `identifier:(gd77\-05\-08...)` fails while the unescaped form works. Drop `+ - & | "` from the escape set (they don't need escaping mid-value on archive.org anyway). Keep escaping the parser characters #70 needed (`( ) { } [ ] ^ ~ : \ / !`), which ES accepts escaped. Verified live against advancedsearch.php. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cf7er8mrabacGCMtLjd6mQ
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage 92.55% 92.55%
=======================================
Files 13 13
Lines 672 672
=======================================
Hits 622 622
Misses 50 50 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96.
#70backslash-escaped the full Lucene special set in non-exactMatch values, but archive.org's Elasticsearch backend errors on the escaped operators (\-,\+,\&,\|,\").-is in nearly every etree recording identifier, soidentifier:(gd77\-05\-08...)fails while the unescaped form works.Drops
+ - & | "from the escape set (they don't need escaping mid-value on archive.org anyway). Keeps escaping the parser characters#70needed (( ) { } [ ] ^ ~ : \ / !), which ES accepts escaped.Verified live against
advancedsearch.php:\-\+\&\|\"→BACKEND_ERROR;\[\(\:etc → fine; unescaped-→ works.All query/escaping tests pass. (The two live-network
scrapeTotalintegration tests fail against archive.org's currently-flaky scrape backend onmaintoo — unrelated.)🤖 Generated with Claude Code
https://claude.ai/code/session_01Cf7er8mrabacGCMtLjd6mQ