Fix: standardize on expires_at, drop duplicate funding_expires_at in WapuPay orders - #129
Draft
andycreed0x wants to merge 10 commits into
Draft
Fix: standardize on expires_at, drop duplicate funding_expires_at in WapuPay orders#129andycreed0x wants to merge 10 commits into
andycreed0x wants to merge 10 commits into
Conversation
The tool reference tables only covered the original wallet/BTC/Liquid/ Lightning tools; SideSwap, SideShift, Changelly, WapuPay, JAN3 account, qr_generate, and doctor were all missing. Also trims a few stale docstrings/comments left over from the doctor feature.
Bump the beta segment on every develop push via scripts/bump_beta.py, commit it back, then build and publish to TestPyPI. main no longer triggers the workflow; PyPI stays release-only. Move PUBLISHING.md to docs/.
develop's required-checks ruleset rejects GITHUB_TOKEN pushes since the bump commit can never carry a passing "Run tests" run. Use a repo deploy key (DEVELOP_DEPLOY_KEY secret), which is an explicit bypass actor on the ruleset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
WapuPay's order responses only ever return
expires_at; the codebase also carried a redundantfunding_expires_atfield that duplicated it. This drops the duplicate and standardizes onexpires_atend-to-end.Targets
use-lbtc-on-wapupay(#122) instead ofdevelopso it merges together with the L-BTC funding-rail work, since both touchWapuPayOrder/wapupay.py.Main Changes
funding_expires_atfield fromWapuPayOrderand_TENTATIVE_RESP_FIELDS—expires_atis now the single source of truthWapuPayManager's funding-window display now readsorder.expires_atserver.py,tools.py) to referenceexpires_attests/test_wapupay.pyand the manual test script (scripts/prompts/prompt_test_wapupay.md) to matchfunding_expires_atis removed from thewapupay_create_order/ order-status response shape. Any caller reading that field directly (instead ofexpires_at) needs to switch.Checklist