fix(example): make play-mode pass lint#2274
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
| } catch { | ||
| let normalized = arrayLiteral; | ||
| normalized = normalized.replace(/'((?:[^'\\]|\\.)*)'/g, (_match, inner: string) => { | ||
| const escaped = inner.replace(/\\'/g, "'").replace(/"/g, '\\"'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
A fresh
hyperframes@0.7.54 init --example play-modescaffold fails its own lint gate with five errors: four CSS/GSAP transform conflicts and one transcript parse error. The transcript error also conflicts with the formatter, which removes unnecessary property-key quotes, and with Studio, which already accepts unquoted JavaScript keys.How
The stats composition now initializes scale, rotation, centering, and transform origins through deterministic
tl.setcalls before its existing tweens. Caption lint uses the same conservative normalization as the Studio parser for single quotes, unquoted keys, and trailing commas while still rejecting unsupported syntax.Test plan
bun run --filter @hyperframes/lint test(364 passed)bun run --filter @hyperframes/lint typecheckbun run --filter @hyperframes/lint buildbunx oxfmt --checkon all changed filesbunx oxlinton changed TypeScript files