fix: resolve pip dependency conflict in trace-log-correlation-exemplars smoke test#313
Open
Jayclifford345 wants to merge 2 commits into
Open
fix: resolve pip dependency conflict in trace-log-correlation-exemplars smoke test#313Jayclifford345 wants to merge 2 commits into
Jayclifford345 wants to merge 2 commits into
Conversation
opentelemetry-sdk 1.43.0 requires opentelemetry-semantic-conventions 0.64b0, but opentelemetry-instrumentation-flask was still pinned to 0.63b1 (which requires semantic-conventions 0.63b1), breaking the smoke test's pip install with ResolutionImpossible. Bump the flask instrumentation pin to 0.64b0 to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opentelemetry-python-monorepoRenovate PR (chore(deps): update opentelemetry-python monorepo to v1.43.0 #308) bumpedopentelemetry-api/opentelemetry-sdkto 1.43.0 intrace-log-correlation-exemplars/app/requirements.txt, but leftopentelemetry-instrumentation-flaskpinned at0.63b1.opentelemetry-sdk==1.43.0requiresopentelemetry-semantic-conventions==0.64b0, whileopentelemetry-instrumentation-flask==0.63b1requiresopentelemetry-semantic-conventions==0.63b1— pip can't satisfy both, sopip installfails withResolutionImpossible, and theSmoke test (trace-log-correlation-exemplars)CI job fails.mainvia the Renovate PR before I caught the break, so this PR fixes it directly onmain.Fix
Bump
opentelemetry-instrumentation-flaskto0.64b0, which requiresopentelemetry-semantic-conventions==0.64b0— matching the SDK.Test plan
docker buildon the scenario's app image succeeds (previously failed withResolutionImpossible)docker compose up -dbrings up the full stack (demo-app, alloy, prometheus, tempo, grafana) cleanly/metricswhile runningdocker compose down --volumes --remove-orphanstears down cleanly