Fix output-diff publishing and post a new comment per run#3081
Merged
Conversation
No generated-output differences✅ This PR does not change generated outputs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Support stacked PRs
The trusted publisher previously required every PR to target
master. PR #3080 targets another branch, so its valid artifact was rejected and no report/comment was created.When
workflow_runsupplies an exact PR number, validate that number plus the event's head repository, branch, and SHA without requiring a default-branch base. For fork events that omit the PR number, require exactly one open PR associated with the event's head owner and branch.Post every current comparison as a new comment
Stop finding and patching an older marker-tagged output-diff comment. Every completed comparison for the PR's current head now creates a new comment, whether outputs differ or are clean. Stale comparisons still cannot comment.
Verification
POST, with no comment lookup orPATCHpath.git diff --checkpass.