Skip to content

fix(bundler): do not import type from optional peer dep#22304

Merged
isaacs merged 1 commit into
developfrom
isaacs/fix-22296-rollup-types-optional-dep
Jul 16, 2026
Merged

fix(bundler): do not import type from optional peer dep#22304
isaacs merged 1 commit into
developfrom
isaacs/fix-22296-rollup-types-optional-dep

Conversation

@isaacs

@isaacs isaacs commented Jul 15, 2026

Copy link
Copy Markdown
Member

fix: #22296
fix: JS-3054

@isaacs isaacs requested a review from timfish July 15, 2026 18:35
@linear-code

linear-code Bot commented Jul 15, 2026

Copy link
Copy Markdown

JS-3054

@timfish

timfish commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Is there any way we can prevent this regressing in CI?

Would we have to install with pnpm and then run Typescript against every export?

@isaacs isaacs merged commit 6370c7d into develop Jul 16, 2026
51 of 52 checks passed
@isaacs isaacs deleted the isaacs/fix-22296-rollup-types-optional-dep branch July 16, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@sentry/bundler-plugins imports types from rollup, which causes a TS error because it's an optional dependency

2 participants