fix(playstation): Add compression limit#6211
Draft
tobias-wilfert wants to merge 3 commits into
Draft
Conversation
tobias-wilfert
commented
Jul 10, 2026
Comment on lines
-62
to
-64
| let data = relay_prosperoconv::extract_data(&prosperodump.payload()).map_err(|err| { | ||
| ProcessingError::InvalidPlaystationDump(format!("Failed to extract data: {err}")) | ||
| })?; |
Member
Author
There was a problem hiding this comment.
tobias-wilfert
commented
Jul 10, 2026
| } | ||
|
|
||
| let decoder = lz4_flex::frame::FrameDecoder::new(Cursor::new(bytes)); | ||
| let mut decoder = decoder.take(limit.saturating_add(1) as u64); |
Member
Author
There was a problem hiding this comment.
Mimics the existing logic here:
relay/relay-server/src/endpoints/minidump.rs
Line 178 in 84e052a
jjbayer
reviewed
Jul 10, 2026
| let data = relay_prosperoconv::extract_data(&prosperodump.payload()).map_err(|err| { | ||
| ProcessingError::InvalidPlaystationDump(format!("Failed to extract data: {err}")) | ||
| })?; | ||
| let data = uncompress( |
Member
There was a problem hiding this comment.
Did extract_data previously do the compression? If so, wouldn't it make more sense to pass a limit parameter into extract_data, so it can not be abused from (hypothetical) other call sites?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: INGEST-994 (More detail in the comments on the ticket).