Serialize a number of plugins. - #7096
Merged
gassmoeller merged 2 commits intoJul 25, 2026
Merged
Conversation
Contributor
Author
|
Part of #6744. |
bangerth
force-pushed
the
pr-fb109c31deed67a2d7706a201a78250f6cb50a34
branch
from
July 23, 2026 17:18
392dde7 to
da8bec9
Compare
Member
|
Can you look into test failures? |
bangerth
force-pushed
the
pr-fb109c31deed67a2d7706a201a78250f6cb50a34
branch
from
July 24, 2026 08:39
da8bec9 to
25d055b
Compare
bangerth
force-pushed
the
pr-fb109c31deed67a2d7706a201a78250f6cb50a34
branch
from
July 24, 2026 11:46
25d055b to
a13cb0b
Compare
Contributor
Author
|
Seems to work now! |
Contributor
Author
|
Ping? |
gassmoeller
approved these changes
Jul 25, 2026
gassmoeller
left a comment
gassmoeller
left a comment
Member
There was a problem hiding this comment.
Yes, thanks for fixing these!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serialize a number of plugins that we had no means so far to serialize themselves -- we simply didn't implement the relevant
save()andload()functions. This is the uncontroversial part of the patches here, as it just adds the relevant functions so that these plugins can be serialized. It's for different patches to actually do that.Found and fixed by Copilot.
Describe what you did in this PR and why you did it.
Before your first pull request:
For all pull requests:
For new features/models or changes of existing features: