Support brightness override in a11y page #9898
Open
hannah-hyj wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the VM service extension integration for overriding brightness in the accessibility controls. It defines the brightnessMode service extension, updates the AccessibilityController to listen to device-side brightness changes, and sends updates back to the VM service when changed via the DevTools UI. Additionally, it adds corresponding analytics constants and comprehensive tests. The reviewer raised a concern regarding potential feedback loops and redundant VM service calls when brightness changes originate from the device itself, suggesting a boolean guard to prevent unnecessary updates.
hannah-hyj
force-pushed
the
a11y_brightness
branch
from
July 16, 2026 20:55
32aec8c to
cd275cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #9893
Screen.Recording.2026-07-16.at.13.41.32.mov
the ext.flutter.brightnessOverride service extension and VM service support to Flutter was added a while ago in PR #59571
Pre-launch Checklist
General checklist
///).Issues checklist
contributions-welcomeorgood-first-issuelabel.contributions-welcomeorgood-first-issuelabel. I understand this means my PR might take longer to be reviewed.Tests checklist
AI-tooling checklist
Feature-change checklist
release-notes-not-requiredlabel or left a comment requesting the label be added.packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.If you need help, consider asking for help on Discord.