feat: export RuleConfig and RuleConfigPatch right in dart_skills_lint.dart#182
Merged
reidbaker merged 1 commit intoJul 16, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request exports the 'rule_config.dart' model from the main 'dart_skills_lint.dart' library, allowing it to be accessed publicly. Consequently, direct internal imports of 'rule_config.dart' in 'api_defaults_test.dart' and 'rule_config_test.dart' have been removed in favor of importing the main package. There are no review comments, and I have no additional feedback to provide.
reidbaker
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes
src/models/rule_config.dartright across the public library entrypoint (lib/dart_skills_lint.dart) so external downstream consumers right can instantiateRuleConfigandRuleConfigPatchdirectly when migrating off deprecatedresolvedRulesarguments ontoresolvedRuleConfigswithout requiring implementation imports.export 'src/models/rule_config.dart';directly acrosslib/dart_skills_lint.dart.test/api_defaults_test.dartandtest/rule_config_test.dartto verify clean public class resolution.dart analyze --fatal-infos .) and cleanly passed all 207 unit tests.